Avoid saving the texture_rd_rid property of TextureRD resources
#87541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(remember to quote annotations so you don't tag accounts) |
RIDs do not persist between runs, so they should not be saved
clayjohn
force-pushed
the
TextureRD-property
branch
from
de28e76 to
c6316bf
Compare
AThousandShips
approved these changes
Jan 24, 2024
BastiaanOlij
approved these changes
Jan 25, 2024
|
Thanks! |
akien-mga
changed the title
texture_rd_rid property of TextureRD resources
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an unreported bug I noticed while working on a more advanced demo using Texture2DRDs.
The bug arises when using
@toolscripts that modify Texture2DRds. The engine was saving thetexture_rd_ridproperty to disk and then trying to load and initialize the texture using the old RID. That doesn't work because RIDs don't persist between runs.Also this PR removes the
texture_rd_ridfrom the editor as you can't set the value from editor. It has to be set at run time after allocating an RD texture and obtaining its RID.CC @BastiaanOlij