Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix freeze in TextEdit with scroll_past_end_of_file and fit_content_height #87880

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Fix freeze in TextEdit with scroll_past_end_of_file and fit_content_height #87880

merged 1 commit into from
Feb 5, 2024

Conversation

kitbdev
Copy link
Contributor

@kitbdev kitbdev commented Feb 2, 2024

scroll_past_end_of_file and fit_content_height don't make sense together so scroll_past_end_of_file now needs fit_content_height to be false.

@kitbdev kitbdev requested a review from a team as a code owner February 2, 2024 21:47
@YeldhamDev YeldhamDev added this to the 4.3 milestone Feb 2, 2024
@KoBeWi
Copy link
Member

KoBeWi commented Feb 4, 2024

This should probably be mentioned in the description of fit_content_height.

@kitbdev
Copy link
Contributor Author

kitbdev commented Feb 4, 2024

The description for scroll_fit_content_height says '[TextEdit] will disable vertical scroll', so it should be clear that scroll_past_end_of_file, scroll_v_scroll_speed, set_line_as_first_visible(), adjust_viewport_to_caret(), and other things related to vertical scrolling won't do anything, right?

@KoBeWi
Copy link
Member

KoBeWi commented Feb 4, 2024

Makes sense.

@akien-mga akien-mga changed the title Fix freeze in TextEdit with scroll_past_end_of_file and fit_content_height Fix freeze in TextEdit with scroll_past_end_of_file and fit_content_height Feb 5, 2024
@akien-mga akien-mga merged commit c23cc08 into godotengine:master Feb 5, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@kitbdev kitbdev deleted the fix-textedit-freeze branch February 5, 2024 16:43
@TheSofox
Copy link
Contributor

Thanks, this bug was driving me nuts when I was trying to fix it. Glad you sorted it out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KoBeWi KoBeWi KoBeWi approved these changes

Assignees
No one assigned
Labels
bug topic:gui
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

CodeEdit.duplicate_lines freeze Godot
5 participants
@kitbdev @KoBeWi @akien-mga @TheSofox @YeldhamDev