Add 'Skip to next (text) occurrence' feature to text editor

[TontonSancho]

Adds ui_text_skip_selection_for_next_occurrence action and related implementation to text editor. This action is bound to Ctrl+Alt+D shorcut.

Used in conjunction with ui_add_selection_for_next_occurrence, it gives the user the ability to select many occurrences of a selection and avoid some of them.
Used without a previous selection, the action jumps to the next occurrence of the current word under the caret.

[Calinou]

Tested locally, it works as expected.

The behavior when you already have many occurrences selected and skip through an existing selection is a bit strange though. It's expected that these entries are deselected, but it cycles in an unusual order. In this video, I select all occurrences then skip through all occurrences:

simplescreenrecorder-2024-02-03_23.43.03.mp4

Nonetheless, it's not critical and I think having this is a big improvement already.

[TontonSancho]

The behavior when you already have many occurrences selected and skip through an existing selection is a bit strange though. It's expected that these entries are deselected, but it cycles in an unusual order. In this video, I select all occurrences then skip through all occurrences:

Yes, I totally caught that during my manual testing. It's mainly due to the first assumption done :

int caret = get_caret_count() - 1;

which gets the last created caret selection to do later stuff in the skip process.

I faced a lots of these "side effects" and this current (final'ish) behavior/implementation is a a trade off I made for this tiny ('n apparently) simple feature without completely the code base around it 😅.

I agree with you ('n thank you for that ❤️) the current state is acceptable.
It will be awesome if someone with UX skills could define these kind of feature in the future.

To forecast future implementation needs, It may be useful to have the following text_edit.cpp improvements :

• FIFO caret storage
• text search method returning position start and position end (will simplify new_caret / and new selection computation)

Regards

[akien-mga]

@TontonSancho FYI, you marked some review comments as done, but there hasn't been a change to the PR yet. Maybe you're still working on it right now, but in case you thought this was updated already, it seems actually pushing your changes is missing.

Note: Please make modifications by amending the commit, and force pushing the changes, so that it stays as a single commit (see PR workflow).

[TontonSancho]

@TontonSancho FYI, you marked some review comments as done, but there hasn't been a change to the PR yet. Maybe you're still working on it right now, but in case you thought this was updated already, it seems actually pushing your changes is missing.

^_^' It was building/testing on my side ...

Note: Please make modifications by amending the commit, and force pushing the changes, so that it stays as a single commit (see PR workflow).

I finally rebased and squashed the feature into a single commit.

[akien-mga]

Thanks! And congrats for your first merged Godot contribution 🎉