[GDScript] Prevent running String number functions on invalid literal
#87941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
added
bug
topic:gdscript
cherrypick:4.2
AThousandShips
commented
Feb 4, 2024
Comment on lines
+830
to
+833
| error.start_column = column; | ||
| error.leftmost_column = column; | ||
| error.end_column = column + 1; | ||
| error.rightmost_column = column + 1; |
There was a problem hiding this comment.
Unsure if the full error info is required here, but added it for completeness, unsure what the difference here is to not using it like below
There was a problem hiding this comment.
I think it is right. Such errors should be reported as a cursor rather than a selection.
dalexeev
reviewed
Feb 4, 2024
Prevents printing excessive errors.
AThousandShips
force-pushed
the
num_fix
branch
from
579601a to
66d55e6
Compare
dalexeev
approved these changes
Feb 4, 2024
|
Thanks! |
|
Thank you! |
|
Cherry-picked for 4.2.2. |
akien-mga
removed
the
cherrypick:4.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents printing excessive errors.
We could also just remove the error print in
hex_to_intbut it was added quite a while ago and is a good indication of what's wrong when parsing strings IMO, and at least I don't think it should be removed just to prevent an annoying print in the GDScript parser (I'd even argue we might want to add errors tobin_to_intand the others)Literals containing decimal points will already stop consuming input before them so that won't trigger an error print on that part (other than the GDScript tokenizer error, but the annoying part is the print to console)