Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Web] Refactor Editor web server. #88063

Merged
merged 2 commits into from
Feb 8, 2024
Merged

[Web] Refactor Editor web server. #88063

merged 2 commits into from
Feb 8, 2024

Conversation

Faless
Copy link
Collaborator

@Faless Faless commented Feb 7, 2024

Move implementation to cpp file.

Move polling thread to EditorHTTPServer class.

Fixes #87994

@Faless Faless requested a review from a team as a code owner February 7, 2024 15:18
@Faless Faless added this to the 4.3 milestone Feb 7, 2024
@Faless Faless force-pushed the web/editor_server_refactor branch from 28039b0 to fdf6fa8 Compare February 7, 2024 19:40
AThousandShips
AThousandShips approved these changes Feb 7, 2024
View reviewed changes
Copy link
Member

@AThousandShips AThousandShips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not familiar with the details of the network code but looks good threading wise

@akien-mga akien-mga merged commit af645c4 into godotengine:master Feb 8, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@Faless Faless deleted the web/editor_server_refactor branch February 8, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AThousandShips AThousandShips AThousandShips approved these changes

@RandomShaper RandomShaper Awaiting requested review from RandomShaper

Assignees
No one assigned
Labels
bug topic:editor
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

Data race in NetSocketPosix::close() detected by ThreadSanitizer
3 participants
@Faless @akien-mga @AThousandShips