Show update spinner by default in dev_build=yes editor builds
#88106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
approved these changes
Feb 8, 2024
akien-mga
reviewed
Feb 8, 2024
| @@ -6476,7 +6486,6 @@ EditorNode::EditorNode() { | |||
| register_exporters(); | |||
|
|
|||
| EDITOR_DEF("interface/editor/save_on_focus_loss", false); | |||
| EDITOR_DEF("interface/editor/show_update_spinner", false); | |||
There was a problem hiding this comment.
Moving this to editor_settings.cpp seems to have added it properly to the docs.
So it seems all these properties may be missing from the docs and should be moved too (in a separate PR).
Calinou
force-pushed
the
editor-dev-build-show-update-spinner
branch
from
206ede0 to
532e73c
Compare
Calinou
force-pushed
the
editor-dev-build-show-update-spinner
branch
from
532e73c to
dafbde4
Compare
Mickeon
approved these changes
Feb 8, 2024
Mickeon
reviewed
Feb 8, 2024
This ensures contributors can see when something forces the editor to redraw constantly. The existing boolean `true` value will be casted to `1` in the setting, so it'll switch to Enabled automatically if the setting was previously enabled.
Calinou
force-pushed
the
editor-dev-build-show-update-spinner
branch
from
dafbde4 to
7e25292
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures contributors can see when something forces the editor to redraw constantly.
The existing boolean
truevalue will be casted to1in the setting, so it'll switch to Enabled automatically if the setting was previously enabled. If the setting is disabled, it'll default to Auto (enabled on dev builds, disabled otherwise).