Tweak property order in the inspector for OptionButton

[Ratamacue9112]

Fixes #88141. Moves the items property to below other properties.

[Ratamacue9112]

There was a comment that said:
// "selected" property must come after "item_count", otherwise GH-10213 occurs.
However when I reordered it, no errors were thrown. I'm guessing this was fixed at some point and the comment was never removed.

[KoBeWi]

I think ADD_ARRAY_COUNT does the declaration.

[AThousandShips]

That's true! Got it confused because of the slightly backwards named comment, would be clearer if it said must come before "selected"

Note though @Ratamacue9112 that this isn't an error being thrown, so make sure to check the issue report to make sure it doesn't reappear:

• OptionButton selected value always set to 0 when run #10213

Because this was solved by moving this exact thing to where it is

[AThousandShips]

This does indeed break the class, and selected breaks with this change, it works fine without this change

[Ratamacue9112]

Ah sorry, didn't notice that. I'm trying to work out a fix now, any suggestions?

[AThousandShips]

No, it'd require quite a bit of reorganization I think, you can't change any of the names of the properties, and we can't delay initializing this property, so I'm not sure how it would be possible to fix this without reworking quite a bit

[KoBeWi]

The initializing can be delayed. You can add a new boolean e.g. initialized and if selected is out of index and initialized is false, store it into e.g. a new queued_selected variable. Then in NOTIFICATION_POSTINTIALIZE check if queued_selected was changed and if it was, assign it to selected. Also set initialized to true.

[AThousandShips]

It's true we can delay the rest of the processing, what I meant was that we can't directly delay it with some property flag, hence the rework need

[Ratamacue9112]

@KoBeWi Where should I put the check for selected being out of index? I've tried it in a few places, which don't seem to work, but I might just be doing it wrong.

[KoBeWi]

It should be in the setter.

[Ratamacue9112]

I've fixed it now. It only worked when I put check if queued_current was changed in the set_item_count method, instead of in NOTIFICATION_POSTINITIALIZE. I don't know if that affects anything else.

[AThousandShips]

I will test this out later today :)

[AThousandShips]

Tested and works correctly, thank you!

[akien-mga]

Thanks! And congrats for your first merged Godot contribution 🎉