Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vertical alignment of editor version LinkButton in the bottom panel #88197

Merged

Conversation

passivestar
Copy link
Contributor

Closes #88196

@AThousandShips AThousandShips added bug topic:editor topic:gui cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels Feb 11, 2024
@AThousandShips AThousandShips added this to the 4.3 milestone Feb 11, 2024
@AThousandShips AThousandShips requested a review from a team February 11, 2024 09:29
@passivestar

This comment was marked as resolved.

@passivestar passivestar force-pushed the version-vertical-alignment branch from 7801607 to c8beb1a Compare February 12, 2024 07:21
@passivestar
Copy link
Contributor Author

Removed the box container

Screen.Recording.mp4

@passivestar
Copy link
Contributor Author

Took another look to make sure this doesn't break anything. Can't find anything trying to reference that box container indirectly, from what I understand it's not common in engine code to do that and it would have been made public if it was of any interest outside of class. Seems safe to remove

So I think this is ready for review

If relevant here's a theme that sets Button's top and bottom margins to abnormally high values for testing (it will make the bottom panel higher):

[gd_resource type="Theme" load_steps=2 format=3 uid="uid://dup750ctlh6cd"]

[sub_resource type="StyleBoxEmpty" id="StyleBoxEmpty_s86oa"]
content_margin_top = 40.0
content_margin_bottom = 40.0

[resource]
Button/styles/normal = SubResource("StyleBoxEmpty_s86oa")

Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Needs a rebase.

@passivestar passivestar force-pushed the version-vertical-alignment branch from c8beb1a to a03315e Compare March 6, 2024 13:48
@passivestar passivestar requested review from a team as code owners March 6, 2024 13:48
@akien-mga akien-mga merged commit 47429b6 into godotengine:master Mar 6, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@passivestar passivestar deleted the version-vertical-alignment branch March 7, 2024 00:08
@akien-mga akien-mga removed the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The editor version LinkButton isn't centered vertically
3 participants