Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asset Library author link, description popup size and UX details #88229

Merged

Conversation

ckaiser
Copy link
Contributor

@ckaiser ckaiser commented Feb 12, 2024

I noticed that the asset library had some weird UI stuff, especially LinkButtons that didn't do anything when clicked, so I've made some minor visual and UX adjustments, mainly:

  • The items are more compact and the license label is no longer misaligned with the image/text
  • The asset name is no longer clickable without it having any effect when the same Item node is used inside of the description window
  • Added tooltips to the asset author and license labels
  • The preview UI in the description window is now hidden when the asset does not have any preview media to show, like code-only assets.
  • Clicking on the author now redirects to the asset store web, filtering by it. This is the one that I'd need some maintainer feedback on: I made it so that it would do nothing (like before) when the repository is not the default Godot one, since I'm not entirely sure if alternate repositories would benefit from linking to the main asset library. The alternative to this implementation could be just making this a label like the license one, since right now it's a confusing that it's clickable but nothing happens.

Before/After:

asset_library_item_before
asset_library_item_after

asset_library_description_before
asset_library_description_after

@ckaiser ckaiser force-pushed the feature/asset_library_ux_cleanup branch from 472d324 to 66f4b97 Compare February 12, 2024 04:16
@akien-mga akien-mga requested a review from Calinou February 12, 2024 07:48
@akien-mga akien-mga added this to the 4.x milestone Feb 12, 2024
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, it mostly works as expected.

  • Added tooltips to the asset author and license labels

I noticed this tooltip is visible in the asset list, but not in the asset details popup (where author name isn't clickable). In comparison, the license tooltip appears in both (even though it's clickable in neither case).

@ckaiser ckaiser force-pushed the feature/asset_library_ux_cleanup branch from 66f4b97 to c8e9254 Compare February 14, 2024 03:25
@ckaiser
Copy link
Contributor Author

ckaiser commented Feb 14, 2024

I noticed this tooltip is visible in the asset list, but not in the asset details popup (where author name isn't clickable). In comparison, the license tooltip appears in both (even though it's clickable in neither case).

Oh yeah, I missed that, thanks!. Using MOUSE_FILTER_IGNORE to avoid LinkButton changing the cursor and hover text color had that unintended side effect, fixed.

Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good to merge after applying the suggestion.

@ckaiser ckaiser force-pushed the feature/asset_library_ux_cleanup branch from c8e9254 to 38ac946 Compare February 14, 2024 09:01
@akien-mga akien-mga merged commit c5050f9 into godotengine:master Feb 14, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@akien-mga akien-mga modified the milestones: 4.x, 4.3 Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants