Visual Studio: Don't override user options. Add additional vs hint information #88244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure we include any user-specified project settings in our project definitions, this way users can customize their VS environment to more closely match what they're building for, and they better can control debugging and deployment from VS. Add support for setting VS-only compiler defines, include paths, and additional linker options, as a hint to VS to use when loading projects and parsing code. VS would usually know these on non nmake projects, but for nmake projects we have to tell it about any implicit information that the compiler has, so it can resolve symbols in the editor.
aaronfranke
changed the title
mhilbrunner
approved these changes
Apr 7, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All of
NMakePreprocessorDefinitions/NMakeIncludeSearchPath/AdditionalOptionsentries that we generate are hints to VS about where to find things, what defines are active, etc, and they're generated based on what scons knows about a particular build configuration. However, there's a lot of implicit compiler settings (like default include paths, default defines, etc), that the compiler adds automatically and that scons can't tell us about. For VS to resolve things more accurately in the editor, either the user or the platform (or both!) need to add some extra information.This PR makes sure both users and our build system can add additional information to VS about where things are found and what things are defined. It also lets users customize the binary name, in case they want to debug or deploy from VS and the final deployed binary name differs from the default one.
/cc @akien-mga @bruvzg @mhilbrunner
Contrbuted by W4Games ❤️