Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C#: Run source generators tests in CI #88295

Merged
merged 1 commit into from
Feb 20, 2024
Merged

C#: Run source generators tests in CI #88295

merged 1 commit into from
Feb 20, 2024

Conversation

raulsntos
Copy link
Member

Runs the test project in CI so that changes to the C# source generators are tested. Not sure which job this should be added to but since it requires building the .NET assemblies, I chose the w/ Mono job.

@raulsntos raulsntos added this to the 4.3 milestone Feb 13, 2024
@raulsntos raulsntos requested a review from a team as a code owner February 13, 2024 20:03
@paulloz
Copy link
Member

paulloz commented Feb 13, 2024

Tests were broken by #87890, because we now generate [ScriptPath(...)] for all generic types.

@raulsntos raulsntos force-pushed the ci/dotnet-generators-tests branch from aefb62f to 34face5 Compare February 14, 2024 05:08
@raulsntos raulsntos requested a review from a team as a code owner February 14, 2024 05:08
akien-mga
akien-mga approved these changes Feb 14, 2024
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

There are a few warnings popping up in the Files view, do you want to address them here or in a follow up?

@raulsntos raulsntos force-pushed the ci/dotnet-generators-tests branch from 34face5 to eb8960d Compare February 14, 2024 13:28
@raulsntos
Copy link
Member Author

@akien-mga

@raulsntos raulsntos marked this pull request as draft February 14, 2024 18:48
@raulsntos raulsntos mentioned this pull request Feb 15, 2024
Merged
This was referenced Feb 17, 2024
Merged
Merged
@raulsntos
C#: Run source generators tests in CI
99b4f30 
Also fixes ScriptPathAttributeGenerator for generic types and its test.
@raulsntos raulsntos force-pushed the ci/dotnet-generators-tests branch from eb8960d to 99b4f30 Compare February 19, 2024 18:42
@raulsntos raulsntos marked this pull request as ready for review February 19, 2024 18:42
@akien-mga akien-mga merged commit ecb21c0 into godotengine:master Feb 20, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@raulsntos raulsntos deleted the ci/dotnet-generators-tests branch February 20, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

@paulloz paulloz paulloz approved these changes

Assignees
No one assigned
Labels
enhancement topic:buildsystem topic:dotnet topic:tests
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
3 participants
@raulsntos @paulloz @akien-mga