Improve Project Settings' Plugin display

[Mickeon]

Partially addresses godotengine/godot-proposals#8438

May provide more screenshots at a later time.

This PR makes a few simple yet notable adjustments to the Project Setting's Plugin section (the Addons):

• The "Enabled" section has been moved to the far left, and has been shortened.
  • See Improve list of plugins display in the Project Settings godot-proposals#8438 (comment) for reasoning.
• Enabled addons display their name in bold;
• The Version section is displayed in monospace;
• Added a bit of padding columns to the left and right;
• The warning message for missing keys in the .cfg file is more concise.
  • Silly warning, by the way. The only truly necessary key is script, I can't think of a reason to require all other fields, as well.

Internally the EditorPluginSettings' code has been restructured a tad, as well.

[vvvvvvitor]

Imo, addons which are enabled should not make their names bold as it's inconsistent with other elements from the editor, I don't remember that happening anywhere else in the editor.

[Mickeon]

See proposal. While it is "inconsistent" there's desire to make enabled addons more noticeable. It does help.
Could you provide other lists in the editor where something similar could be done?

[vvvvvvitor]

See proposal. While it is "inconsistent" there's desire to make enabled addons more noticeable. It does help.
Could you provide other lists in the editor where something similar could be done?

I have read the proposal before posting my comment, I do still think it's weird to include it. I'm not on my computer rn, I'll look for other components asap.

[vvvvvvitor]

Could you provide other lists in the editor where something similar could be done?

I did a quick look through the editor and the only other one I could find was Shader Globals, that page is already pretty similar to the current plugins tab. This is wrong.

[Mickeon]

But Shader Globals cannot be enabled or disabled, they can only be added or removed from the list, so they don't need their name in bold. There may be no precedent to something like this, hence why it looks weird to you?

Autoloads feature a similar list and the logic is similar, too.

The alternative to bold enabled addons could be to... darken disabled addons, instead?

[vvvvvvitor]

But Shader Globals cannot be enabled or disabled, they can only be added or removed from the list, so they don't need their name in bold. There may be no precedent to something like this, hence why it looks weird to you?

I'm pretty sure there were toggles on the Shader Globals tab, let me double check

[vvvvvvitor]

The alternative to bold enabled addons could be to... darken disabled addons, instead?

That could work too, it's even consistent to when you disable a node's process.

[vvvvvvitor]

But Shader Globals cannot be enabled or disabled, they can only be added or removed from the list, so they don't need their name in bold. There may be no precedent to something like this, hence why it looks weird to you?

I'm pretty sure there were toggles on the Shader Globals tab, let me double check

Ah, I see, I mistakenly assumed the variable's bool toggle was a enable/disable toggle.

[AThousandShips]

Looks great otherwise!

[KoBeWi]

You could fetch the font before the loop. Same below (font and icon).

[Mickeon]

The question is whether to do this or make the name more transparent (although in the original proposal no one seemed to mind the bold)

[KoBeWi]

You'd still need to fetch a "disabled" color, no? I mean, it's better to use a defined color than just decrease opacity.

[Mickeon]

Ever since the massive editor theme refactoring I'm not sure how. Do you have a hint?

[KoBeWi]

e.g. get_theme_color(SNAME("font_disabled_color"), EditorStringName(Editor))

[KoBeWi]

Overall looks good.

I think it's worth to try using a different color instead of bold font to differentiate enabled and disabled plugins. Currently it doesn't look that readable with a longer list.

[Mickeon]

Here's a screenshot on how it'd look with the above suggestion

[KoBeWi]

Looks better IMO.
Though the disabled text looks smaller for some reason? 🤔

[Mickeon]

I updated the PR to use the disabled color.

Though the disabled text looks smaller for some reason

That's the drawback. The font size is not changed, it may be just the antialiasing.

[Calinou]

Tested locally, it works as expected.

Code looks good to me.

[akien-mga]

Thanks!