Disable ReShade in the editor and project manager (if run via Vulkan) #88316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReShade can still be used on projects run from the editor as well as exported projects. This avoids several issues: - ReShade doesn't play well with low-processor mode, making it hard to use unless the Update Continuously editor setting is enabled. - The ReShade overlay appears on every popup opened, which made popups unusable. - If you use a ReShade configuration that heavily affects the image, it won't affect the editor UI which may become unreadable as a result. This doesn't affect the editor being run via OpenGL or Direct3D 12 as ReShade is injected in a different manner when using those graphics APIs.
Calinou
added
bug
platform:windows
topic:rendering
topic:thirdparty
cherrypick:4.2
akien-mga
approved these changes
Feb 14, 2024
|
Thanks! |
|
Cherry-picked for 4.2.2. |
akien-mga
removed
the
cherrypick:4.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ReShade can still be used on projects run from the editor as well as exported projects.
This avoids several issues:
This doesn't affect the editor being run via OpenGL or Direct3D 12 as ReShade is injected in a different manner when using those graphics APIs.
Preview
Before this PR, this could happen if ReShade was installed for the Godot editor:
With this PR, you can still run ReShade on projects run from the editor - it just won't apply to the editor itself: