[3.x] Add a get_or_add method to Dictionary
#88345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mickeon
approved these changes
Feb 14, 2024
doc/classes/Dictionary.xml
Outdated
| <argument index="0" name="key" type="Variant" /> | ||
| <argument index="1" name="default" type="Variant" default="null" /> | ||
| <description> | ||
| Gets a value and ensures the key is set. If the [param key] exists in the dictionary, this behaves like [method get]. Otherwise, the [param default] value is inserted into the dictionary and returned. |
There was a problem hiding this comment.
To my personal annoyance and a few others, param does not exist in 3.x.
Suggested change
| Gets a value and ensures the key is set. If the [param key] exists in the dictionary, this behaves like [method get]. Otherwise, the [param default] value is inserted into the dictionary and returned. | |
| Gets a value and ensures the key is set. If the [code]key[/code] exists in the dictionary, this behaves like [method get]. Otherwise, the [code]default[/code] value is inserted into the dictionary and returned. |
SysError99
force-pushed
the
3.x-get_or_add
branch
from
f870e7f to
f37db96
Compare
|
Since this is a functionally identical backport I'd say to add a co-author to this |
SysError99
force-pushed
the
3.x-get_or_add
branch
from
f37db96 to
d4e5370
Compare
This comment was marked as outdated.
This comment was marked as outdated.
SysError99
force-pushed
the
3.x-get_or_add
branch
from
d4e5370 to
2b639f1
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Co-authored-by: Aaron Franke <arnfranke@yahoo.com>
SysError99
force-pushed
the
3.x-get_or_add
branch
from
2b639f1 to
b3f93ad
Compare
AThousandShips
approved these changes
Feb 15, 2024
aaronfranke
approved these changes
Mar 15, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows #78095 that adds
get_or_addmethod toDictionaryfor 3.x branch. This is a very useful function for setting up new parameters into the dictionary or keep using old values from it.