Rotary input for 3.x #88462
Closed
Rotary input for 3.x #88462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlekseyKapustyanenko
force-pushed
the
Rotary-input-3.x
branch
3 times, most recently
from
b24bc7d
to
2ebdbc0
Compare
Mickeon
approved these changes
Feb 17, 2024
AlekseyKapustyanenko
force-pushed
the
Rotary-input-3.x
branch
from
2ebdbc0
to
3a80649
Compare
|
Sorry, I made branch from wrong branch. Therefore I will close this and open new PR after reworking. |
|
How was it the wrong branch? 3.x is where it should be. |
I have made my branch from 3.5. branch. Then I had implemented feature. Then I had realized that correct branch is 3.x. Then I had made patch and applied it to 3.x and made PR. But there is significant changes between 3.5 and 3.x so my patch just breaks 3.x branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Rotary input support for wear os devices. It converts RotaryInput to vertical mouse wheel event. Without it Godot does not recognise this event at all. The same feature wich implemented here , but for Godot 3.x.
Proposal: godotengine/godot-proposals#9062