Clean up and optimize BasisUniversal #88464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm generally ok with this but I agree that testing on mobile devices is required. |
BlueCube3310
force-pushed
the
basisu-cleanup-v2
branch
from
29f74a2 to
e460d1b
Compare
BlueCube3310
force-pushed
the
basisu-cleanup-v2
branch
from
e460d1b to
d97ece5
Compare
|
Unlike our usual practice, such a change would be much easier to review if done as two separate commits: one to move the code to a separate file, and one to actual do logic changes. With both types of changes made in the same commit it's pretty difficult to review. |
BlueCube3310
force-pushed
the
basisu-cleanup-v2
branch
from
d97ece5 to
f6899cb
Compare
|
The commits are now split, as suggested. |
AThousandShips
approved these changes
Feb 19, 2024
BlueCube3310
force-pushed
the
basisu-cleanup-v2
branch
from
f6899cb to
a1997d1
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to clean up BasisUniversal's code to make it easier to read, as well as extracts the code from
register_types.cppinto its own files.It also slightly optimizes the memory usage and compression times by using the
get_mipmap_offset_size_and_dimensions()function instead of copying each mipmap's data into a new image.While it seems to function correctly, it still needs some testing, especially on mobile devices.