Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C#: Document that MainLoop needs to be registered in the global class #88635

Merged
merged 1 commit into from
Feb 22, 2024
Merged

C#: Document that MainLoop needs to be registered in the global class #88635

merged 1 commit into from
Feb 22, 2024

Conversation

SaNeOr
Copy link
Contributor

@SaNeOr SaNeOr commented Feb 21, 2024 •
edited by AThousandShips
Loading

When I tried to use c# to implement a custom MainLoop, I found that it seemed that it had to be registered in the global class for it to work.

@SaNeOr SaNeOr requested a review from a team as a code owner February 21, 2024 16:43
@Calinou Calinou added enhancement documentation cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels Feb 21, 2024
@Calinou Calinou added this to the 4.3 milestone Feb 21, 2024
paulloz
paulloz approved these changes Feb 21, 2024
View reviewed changes
Copy link
Member

@paulloz paulloz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Fixes

@akien-mga akien-mga changed the title Additional docs: c# mainloop needs to be registered in the global class C#: Document that MainLoop needs to be registered in the global class Feb 21, 2024
@akien-mga akien-mga merged commit ac7c763 into godotengine:master Feb 22, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@SaNeOr SaNeOr deleted the master_update_mainloop_docs branch February 26, 2024 04:35
@akien-mga
Copy link
Member

Cherry-picked for 4.2.2.
Cherry-picked for 4.1.4.

@akien-mga akien-mga removed the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mickeon Mickeon Mickeon approved these changes

@paulloz paulloz paulloz approved these changes

Assignees
No one assigned
Labels
documentation enhancement
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

C# code for custom MainLoop missing critical attribute
5 participants
@SaNeOr @akien-mga @paulloz @Mickeon @Calinou