-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Update actions to latest versions, use default runner .NET version #88671
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only the first commit should be cherry-picked.
There's only one commit though. Did you mean to keep the .NET version change in a separate commit?
.github/workflows/linux_builds.yml
Outdated
if: ${{ matrix.build-mono }} | ||
with: | ||
dotnet-version: '6.0.x' | ||
dotnet-version: '8.0.x' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I was wondering where the runtime 6 was coming from. Your link explains it.
be1a789
to
ad8d3cf
Compare
Seems like I didn't push my two-commits version properly in the end. Oh well :D Let's try the version with the dotnet setup step removed, and I'll just special case it when cherry-picking. |
Cherry-picked for 4.2.2. Minus that part:
|
Cherry-picked for 3.6. |
Only the first commit should be cherry-picked.The .NET step change should likely not be cherry-picked.