-
-
Notifications
You must be signed in to change notification settings - Fork 21.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken layout of asset library page #88761
Conversation
I think column problems can also be solved by using HFlowContainer instead of GridContainer, no? |
I see. I'll try it. |
You could try using EXPAND flag on library items, it might force them to have the same size. Though it will break on rows with less items 🤔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well the GridContainer works alright and this fixes the issue.
53a3dea
to
c5cab60
Compare
Thanks! |
Cherry-picked for 4.2.2. |
While reviewing #87407, I came across two additional problems. I've recorded a demo to help explain.
2024-02-24.19-00-55.mp4
The first issue, as described in #87407, occurs when horizontally scaling the project manager window while on the asset library page, resulting in a broken layout.
The second issue occurs when scaling to the point where the third column appears. It becomes evident that the widths of the three columns are not evenly distributed.
The third issue occurs when navigating to the asset library page after opening a project and then scaling. As the number of columns in the asset library increases, it becomes impossible to reduce the number of columns. Even attempting to narrow the width of the asset library doesn't work.
My current solution involves fine-tuning the size of
asset_items_columns_width
and performing a clamp operation each time_update_asset_items_columns
is executed.Below is the demo video of my solution.
2024-02-24.19-04-15.mp4
Also, I noticed a refactor todo item in the
clamp_width
function. However, I found that refactoring theLinkButton
to support ellipsing functionality similar toButton
might not be straightforward for me. I'm also unsure if it would cause some spec changes forLinkButton
, so I haven't tackled it from that angle.Bugsquad edit: