[Animation] Improvements to Tween memory management
#88856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KoBeWi
reviewed
Feb 26, 2024
KoBeWi
reviewed
Feb 26, 2024
Using `ObjectID` instead of manually breaking reference cycles.
AThousandShips
force-pushed
the
tween_fix
branch
from
5ecd287 to
92814ba
Compare
KoBeWi
approved these changes
Feb 26, 2024
|
Thanks! |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
ObjectIDinstead of manually breaking reference cycles.Also removed a duplicate variable
tweeninMethodTweenerLeft the
clearmethod inTween, can remove it if desired but it still has functionality even without its main purpose