Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify C# Color opacity comment #88909

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Clarify C# Color opacity comment #88909

merged 1 commit into from
Feb 27, 2024

Conversation

emre0altan
Copy link
Contributor

Comments are updated for clarity.

@emre0altan emre0altan requested a review from a team as a code owner February 27, 2024 13:31
@paulloz paulloz added this to the 4.3 milestone Feb 27, 2024
raulsntos
raulsntos reviewed Feb 27, 2024
View reviewed changes
Copy link
Member

@raulsntos raulsntos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing to the .NET documentation.

We usually try to match the Core documentation, so I took a look at the documentation for Color and it looks like these changes mostly match the documentation for the a member. I made comments on the parts that are different.

modules/mono/glue/GodotSharp/GodotSharp/Core/Color.cs Outdated Show resolved Hide resolved
modules/mono/glue/GodotSharp/GodotSharp/Core/Color.cs Outdated Show resolved Hide resolved
modules/mono/glue/GodotSharp/GodotSharp/Core/Color.cs Outdated Show resolved Hide resolved
modules/mono/glue/GodotSharp/GodotSharp/Core/Color.cs Outdated Show resolved Hide resolved
modules/mono/glue/GodotSharp/GodotSharp/Core/Color.cs Outdated Show resolved Hide resolved
@emre0altan emre0altan force-pushed the clarify-c#-color-opacity-comment branch from ba7ff57 to 4100a23 Compare February 27, 2024 15:56
raulsntos
raulsntos approved these changes Feb 27, 2024
View reviewed changes
Copy link
Member

@raulsntos raulsntos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@emre0altan
Copy link
Contributor Author

emre0altan commented Feb 27, 2024 •
edited
Loading

Thank you! 🙂

@akien-mga akien-mga merged commit ed2ff19 into godotengine:master Feb 27, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raulsntos raulsntos raulsntos approved these changes

Assignees
No one assigned
Labels
documentation enhancement
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

Change wording from "transparency" to "opacity"
4 participants
@emre0altan @akien-mga @raulsntos @paulloz