Fix crash when selecting re-added TreeItem::Cell
#88917
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #88889.
When removing a
TreeItem
from aTree
it doesn't clear theselected
property of the cells in theTreeItem
, which means that if you remove thisTreeItem
from theTree
and then add it back again, and then select the same item/cell, you wouldn't pass this condition:godot/scene/gui/tree.cpp
Lines 2664 to 2668 in a586e86
Which then left
selected_item
atnullptr
and would subsequently crash here:godot/scene/gui/tree.cpp
Line 3736 in a586e86
This PR fixes this by simply clearing the
selected
property of all the item's cells when it's removed from the tree.