Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure proper vertex input masks are used in 2D compatibility renderer #88938

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

clayjohn
Copy link
Member

Fixes: #88937

There were two problems:

  1. We were using RS::ARRAY_FORMAT_VERTEX | RS::ARRAY_COLOR | RS::ARRAY_TEX_UV (i.e. 1 | 3 | 4 AKA 111) instead of RS::ARRAY_FORMAT_VERTEX | RS::ARRAY_FORMAT_COLOR | RS::ARRAY_FORMAT_TEX_UV AKA 11001
  2. We weren't initializing vertex_input_mask to anything and it wasn't always set so we end up with situations where it contains garbage data

@akien-mga akien-mga merged commit f77bc87 into godotengine:master Feb 28, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2D Skeletons not visible in Compatibility Mode
3 participants