Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTL: Clarify that line, paragraph, and character numbers are zero-indexed #88956

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

akien-mga
Copy link
Member

@akien-mga akien-mga commented Feb 28, 2024

Closes #82885 once cherry-picked to 4.1 with this additional change:

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 895d4da342..52395a3037 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -598,6 +598,7 @@ See the [release announcement](https://godotengine.org/article/maintenance-relea
 #### GUI
 
 - Fix RichTextLabel character line and paragraph index getters ([GH-76759](https://github.com/godotengine/godot/pull/76759)).
+  * This corrects an off-by-one error for the indices, making lines/paragraphs zero-indexed instead of one-indexed.
 - Fix text overlapping icon in `Tree` ([GH-78756](https://github.com/godotengine/godot/pull/78756)).
 - Fix delay on tab resizing when (un)hovering tabs ([GH-78777](https://github.com/godotengine/godot/pull/78777)).
 - Fix `Tree` performance regression by using cache ([GH-79325](https://github.com/godotengine/godot/pull/79325)).

@akien-mga akien-mga added enhancement documentation cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels Feb 28, 2024
@akien-mga akien-mga added this to the 4.3 milestone Feb 28, 2024
@akien-mga akien-mga requested a review from a team as a code owner February 28, 2024 12:47
@akien-mga akien-mga merged commit cc21871 into godotengine:master Feb 29, 2024
16 checks passed
@akien-mga akien-mga deleted the doc-rtl-zero-idx branch February 29, 2024 13:02
@akien-mga
Copy link
Member Author

Cherry-picked for 4.2.2.
Cherry-picked for 4.1.4.

@akien-mga akien-mga removed cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rich Text get_character_line Behavior Changed in 4.1.2
3 participants