Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add const lvalue ref to remaining container parameters #88975

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add const lvalue ref to remaining container parameters #88975

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion drivers/unix/net_socket_posix.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,7 @@ bool NetSocketPosix::_can_use_ip(const IPAddress &p_ip, const bool p_for_bind) c
return !(_ip_type != IP::TYPE_ANY && !p_ip.is_wildcard() && _ip_type != type);
}

_FORCE_INLINE_ Error NetSocketPosix::_change_multicast_group(IPAddress p_ip, String p_if_name, bool p_add) {
_FORCE_INLINE_ Error NetSocketPosix::_change_multicast_group(IPAddress p_ip, const String &p_if_name, bool p_add) {
ERR_FAIL_COND_V(!is_open(), ERR_UNCONFIGURED);
ERR_FAIL_COND_V(!_can_use_ip(p_ip, false), ERR_INVALID_PARAMETER);

Expand Down
2 changes: 1 addition & 1 deletion drivers/unix/net_socket_posix.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ class NetSocketPosix : public NetSocket {

NetError _get_socket_error() const;
void _set_socket(SOCKET_TYPE p_sock, IP::Type p_ip_type, bool p_is_stream);
_FORCE_INLINE_ Error _change_multicast_group(IPAddress p_ip, String p_if_name, bool p_add);
_FORCE_INLINE_ Error _change_multicast_group(IPAddress p_ip, const String &p_if_name, bool p_add);
_FORCE_INLINE_ void _set_close_exec_enabled(bool p_enabled);

protected:
Expand Down
2 changes: 1 addition & 1 deletion main/performance.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,7 +330,7 @@ Performance::Performance() {
singleton = this;
}

Performance::MonitorCall::MonitorCall(Callable p_callable, Vector<Variant> p_arguments) {
Performance::MonitorCall::MonitorCall(Callable p_callable, const Vector<Variant> &p_arguments) {
_callable = p_callable;
_arguments = p_arguments;
}
Expand Down
2 changes: 1 addition & 1 deletion main/performance.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ class Performance : public Object {
Vector<Variant> _arguments;

public:
MonitorCall(Callable p_callable, Vector<Variant> p_arguments);
MonitorCall(Callable p_callable, const Vector<Variant> &p_arguments);
MonitorCall();
Variant call(bool &r_error, String &r_error_message);
};
Expand Down
Loading