Fix issues with text clearing in RichTextLabel
#89100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YeldhamDev
force-pushed
the
tag,_it_is_you!
branch
from
63d6561 to
3b4f157
Compare
Mickeon
reviewed
Mar 3, 2024
YeldhamDev
force-pushed
the
tag,_it_is_you!
branch
from
3b4f157 to
d6917d2
Compare
Mickeon
approved these changes
Mar 3, 2024
There was a problem hiding this comment.
Just nice documentation-wise and this is something I feel like trusting @YeldhamDev in.
|
Thanks! |
|
This seems to have been introduced to 4.2 as well even though originally reported as not being reproducible in 4.2.1, probably through some cherry pick, see: Or a variant of the same at least |
akien-mga
added
the
cherrypick:4.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a couple of bugs and adds some needed doc annotations to
RichTextLabel.text = ""(my bad). Closes 4.3: RichTextLabel.text = "" no longer clears contents and RichTextLabel.clear() no longer has an effect outside of scene tree #89091.text = ""not clearing the tag stack iftextis already empty.