Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Wayland] Fix tilt handling #89112

Merged
merged 1 commit into from
Mar 4, 2024
Merged

[Wayland] Fix tilt handling #89112

merged 1 commit into from
Mar 4, 2024

Conversation

AThousandShips
Copy link
Member

Haven't seen any reports on this but assuming this is a typo, replaced with Vector2::clamp for safety (discovered while working on #89111, and does if this is a bug show the value of that IMO)

@AThousandShips AThousandShips added this to the 4.3 milestone Mar 3, 2024
@AThousandShips AThousandShips requested a review from a team as a code owner March 3, 2024 11:52
@AThousandShips AThousandShips requested a review from Riteo March 3, 2024 11:54
Riteo
Riteo reviewed Mar 3, 2024
View reviewed changes
Copy link
Contributor

@Riteo Riteo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops 😅

Just a quick question regarding Vector2::clamp, see the comment.

platform/linuxbsd/wayland/wayland_thread.cpp Show resolved Hide resolved
platform/linuxbsd/wayland/wayland_thread.cpp Show resolved Hide resolved
Riteo
Riteo approved these changes Mar 3, 2024
View reviewed changes
Copy link
Contributor

@Riteo Riteo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is another of those magical moments where code that shouldn't run worked anyways.

The Vector2::clamp thing is a really nice trick and I really hope that #89144 gets through, it would be real nifty :D

Thanks!

@AThousandShips AThousandShips requested a review from Riteo March 3, 2024 18:01
@AThousandShips
Copy link
Member Author

Fixed the type, it's only used in two places and it always seems to assume Vector2

@Riteo
Copy link
Contributor

Riteo commented Mar 3, 2024

@AThousandShips WTF, I have absolutely no idea on how it is a Vector2i and how it clearly managed to report fractional results, now I'm seriously confused :/

Oh well, thanks a lot for fixing the type, that's the correct solution indeed.

Are computers even real at this point lmao

@AThousandShips AThousandShips changed the title [Wayland] Fix typo in tilt handling [Wayland] Fix tilt handling Mar 3, 2024
@akien-mga akien-mga merged commit 790d051 into godotengine:master Mar 4, 2024
16 checks passed
@AThousandShips AThousandShips deleted the wayland_tilt branch March 4, 2024 13:12
@akien-mga
Copy link
Member

Thanks!

@AThousandShips
Copy link
Member Author

Thank you!

@winston-yallow
Copy link
Contributor

winston-yallow commented Mar 4, 2024 •
edited
Loading

For the record, tested this with my tablet and everything works perfectly 🎉
(yeah I'm a bit late ahaha)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Riteo Riteo Awaiting requested review from Riteo

Assignees
No one assigned
Labels
bug platform:linuxbsd topic:porting
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
4 participants
@AThousandShips @Riteo @akien-mga @winston-yallow