Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update file dialog filter documentation #89150

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

RedMser
Copy link
Contributor

@RedMser RedMser commented Mar 4, 2024

Certain that this works for Windows, might need tweaked documentation for other platforms.

@RedMser RedMser requested a review from a team as a code owner March 4, 2024 17:45
@AThousandShips AThousandShips added this to the 4.3 milestone Mar 4, 2024
@RedMser RedMser force-pushed the file_dialog_show_docs branch from 310fc85 to b0ae0cd Compare March 4, 2024 17:56
@akien-mga akien-mga requested a review from bruvzg March 4, 2024 18:15
@RedMser RedMser force-pushed the file_dialog_show_docs branch from b0ae0cd to 3d4f4a8 Compare March 4, 2024 19:10
@RedMser RedMser changed the title Document DisplayServer.file_dialog_show filters parameter Update file dialog filter documentation Mar 4, 2024
@RedMser
Copy link
Contributor Author

RedMser commented Mar 4, 2024

Also updated the filters documentation of FileDialog, since it used an outdated setter-function syntax and was generally harder to understand.

@RedMser

This comment was marked as outdated.

@RedMser RedMser force-pushed the file_dialog_show_docs branch from 3d4f4a8 to 6415ac2 Compare March 4, 2024 19:12
Copy link
Contributor

@Mickeon Mickeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akien-mga akien-mga merged commit e7039cd into godotengine:master Mar 4, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants