Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose PrimitiveMesh's request_update method #89170

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

jsjtxietian
Copy link
Contributor

Fixes #89067

@jsjtxietian jsjtxietian requested a review from a team as a code owner March 5, 2024 06:38
@jsjtxietian jsjtxietian marked this pull request as draft March 5, 2024 06:41
@jsjtxietian jsjtxietian force-pushed the expose-request-update branch from 3871350 to ee75e53 Compare March 5, 2024 06:46
@jsjtxietian jsjtxietian marked this pull request as ready for review March 5, 2024 06:46
@akien-mga akien-mga changed the title Expose PrimitiveMesh's _request_update method Expose PrimitiveMesh's _request_update method Mar 5, 2024
@Chaosus Chaosus added this to the 4.3 milestone Mar 5, 2024
@jsjtxietian jsjtxietian force-pushed the expose-request-update branch from ee75e53 to 3d337e7 Compare March 6, 2024 09:07
@akien-mga akien-mga changed the title Expose PrimitiveMesh's _request_update method Expose PrimitiveMesh's request_update method Mar 6, 2024
@jsjtxietian
Copy link
Contributor Author

Looks like the function under callable_mp, create_custom_callable_function_pointer uses template as instance type and function type, so it can't deduce the parent/child relation and I have to use static_cast to cast the type and make it compile.

@jsjtxietian jsjtxietian force-pushed the expose-request-update branch from 3d337e7 to 1716f12 Compare March 6, 2024 11:18
@akien-mga akien-mga merged commit 362a088 into godotengine:master Mar 6, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@jsjtxietian jsjtxietian deleted the expose-request-update branch March 6, 2024 14:35
@jsjtxietian
Copy link
Contributor Author

jsjtxietian commented Mar 6, 2024

I just found out this is my 100th commit to godot repo (althoung most of them are trivial), thanks for all of your help along the way :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MeshInstance2D does not update mesh when using custom PrimitiveMesh
6 participants