Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add working ResourceFormatLoaderGDScript::get_dependencies() implementation #89231

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nfranck-toonboom
Copy link

@nfranck-toonboom nfranck-toonboom commented Mar 6, 2024

Remove stub code from GDScripts' get_dependencies implementation, add working code for finding dependencies from parent classes and constant declarations

Bugsquad edit: Linked issue.

Remove stub code from GDScripts' get_dependencies implementation, add working code for finding dependencies from parent classes and constant declarations

Fixes godotengine#51717
@nfranck-toonboom nfranck-toonboom requested a review from a team as a code owner March 6, 2024 21:38
@dalexeev dalexeev added this to the 4.3 milestone Mar 6, 2024
@akien-mga akien-mga changed the title Add working GDScript get_dependencies implementation Add working GDScript get_dependencies implementation Mar 6, 2024
@adamscott adamscott self-assigned this Mar 7, 2024
@adamscott
Copy link
Member

Remove stub code from GDScripts' get_dependencies implementation

For some context, this isn't related to GDScript::get_dependencies() (cyclic dependencies checks). This PR is instead about ResourceFormatLoaderGDScript::get_dependencies() which is called by ResourceFormatLoader.

@fire fire requested a review from a team March 7, 2024 15:41
@adamscott adamscott changed the title Add working GDScript get_dependencies implementation Add working ResourceFormatLoaderGDScript::get_dependencies() implementation Mar 7, 2024
@dalexeev
Copy link
Member

dalexeev commented Jun 6, 2024

See also:

This may be more complicated than it seems. Let's move this to the next milestone. CC @vnen @adamscott

@dalexeev dalexeev modified the milestones: 4.3, 4.4 Jun 6, 2024
@univeous
Copy link
Contributor

univeous commented Dec 11, 2024

You wrote

Fixes #51717.

But this is written in the code

// TODO: references to other scripts through their class_name.

Is this intentional?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants