Allow connecting signals to existing methods without opening the script editor

[passivestar]

Closes godotengine/godot-proposals#8351

Adds an editor setting to prevent the script editor from opening when connecting a signal to an existing method

Note that script editor opening when connecting to an existing method was a bug, but we're preserving that behavior by default

EDIT: Switched from doing this by holding Ctrl when pressing Connect to an editor setting

[Mickeon]

While I do find this to be a decent feature, the editor has a discoverability issue for these kinds of things and this additional CTRL shortcut does not help.

At least, if possible, what I would do is have the text on the change completely when holding the CTRL key. I've never seen something like this done by the editor before, but at least it makes the feature more noticeable.

In my opinion though, this could just as easily be an Editor Setting, or perhaps, a toggle on the Connect dialog itself, or both?

[passivestar]

At least, if possible, what I would do is have the text on the change completely when holding the CTRL key. I've never seen something like this done by the editor before, but at least it makes the feature more noticeable.

I've never seen anything like that either and I'm not sure it would help discoverability if you need to hold CTRL to discover it

In my opinion though, this could just as easily be an Editor Setting, or perhaps, a toggle on the Connect dialog itself, or both?

I'm 100% on board to make it an editor setting (with default being the current behavior) and nothing else. In my opinion it's all that's really needed here, especially considering that editor opening on existing methods was unintended

[KoBeWi]

Seems like it breaks connecting to native methods:

godot.windows.editor.dev.x86_64_wtate8D6jD.mp4

I held Ctrl, but not only it opened the editor, it redefined queue_free().

[passivestar]

Seems like it breaks connecting to native methods

Fixed that and also switched from the modifier key to an editor setting

Here's how it works now:

1. If the method exists in an inherited class, either native or script, it creates a connection without adding anything or opening the editor (as it did before)
2. If the method exists in the script on the target node itself it checks the editor setting to decide whether to open the editor or not

I put it into "Text Editor -> Behavior -> Navigation" (let me know if there's a better place)

[akien-mga]

Thanks!