Fix use after free in GDScriptLanguage::debug_get_globals
#89274
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Object*
cast operator ofVariant
does not validate that the object still exists. This means that in the case you egqueue_free
an autoload class this will crash on the next script error due to trying todynamic_cast
a freed pointer.Not sure
get_validated_object_with_check
is needed or ifget_validated_object
would have been enough. But I think better safe than sorry in this case.There would also be the option of printing a warning/error here since I don't think you should really free autoloads intentionally.