Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wayland: Stop possible Null pointer dereferences #89307

Merged
merged 1 commit into from
Mar 9, 2024
Merged

Wayland: Stop possible Null pointer dereferences #89307

merged 1 commit into from
Mar 9, 2024

Conversation

alesliehughes
Copy link
Contributor

wp_tablet_tool_get_state can return a NullPtr in some cases.

@alesliehughes alesliehughes requested a review from a team as a code owner March 9, 2024 04:07
@AThousandShips AThousandShips added this to the 4.3 milestone Mar 9, 2024
@akien-mga akien-mga added crash and removed crash labels Mar 9, 2024
Riteo
Riteo approved these changes Mar 9, 2024
View reviewed changes
Copy link
Contributor

@Riteo Riteo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! I think that logic might've been something left over by the development of the new tablet handling stuff, although I can't remember more details unfortunately.

@akien-mga akien-mga changed the title wayland: Stop possible Null pointer dereferences Wayland: Stop possible Null pointer dereferences Mar 9, 2024
@akien-mga akien-mga merged commit 3ca230d into godotengine:master Mar 9, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chubercik Chubercik Chubercik approved these changes

@Riteo Riteo Riteo approved these changes

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug crash platform:linuxbsd topic:porting
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
5 participants
@alesliehughes @akien-mga @Riteo @Chubercik @AThousandShips