C#: Fix warnings in GodotSharp

[paulloz]

• Fix most CS0108 in generated glue
• Suppress CA1001 on Variant

---

As discussed on RC. Overall, regarding warnings: we're almost there 😅 I left the CS0108 we currently have on GltfAccessor.GetType() because it is so stinky, we deserve to endure seeing it every time.

Here's the diff of the generated classes.

--- GodotSharp/Generated.old/GodotObjects/ArrayMesh.cs	2024-03-09 16:46:29.047422800 +0100
+++ GodotSharp/Generated/GodotObjects/ArrayMesh.cs	2024-03-09 16:48:42.112835900 +0100
@@ -61,7 +61,7 @@
     /// <summary>
     /// <para>Sets the blend shape mode to one of <see cref="Godot.Mesh.BlendShapeMode"/>.</para>
     /// </summary>
-    public Mesh.BlendShapeMode BlendShapeMode
+    public new Mesh.BlendShapeMode BlendShapeMode
     {
         get
         {
--- GodotSharp/Generated.old/GodotObjects/Button.cs	2024-03-09 16:46:29.125389100 +0100
+++ GodotSharp/Generated/GodotObjects/Button.cs	2024-03-09 16:48:42.191835200 +0100
@@ -182,7 +182,7 @@
     /// <summary>
     /// <para>Base text writing direction.</para>
     /// </summary>
-    public Control.TextDirection TextDirection
+    public new Control.TextDirection TextDirection
     {
         get
         {
--- GodotSharp/Generated.old/GodotObjects/Label.cs	2024-03-09 16:46:29.577388900 +0100
+++ GodotSharp/Generated/GodotObjects/Label.cs	2024-03-09 16:48:42.634867600 +0100
@@ -256,7 +256,7 @@
     /// <summary>
     /// <para>Base text writing direction.</para>
     /// </summary>
-    public Control.TextDirection TextDirection
+    public new Control.TextDirection TextDirection
     {
         get
         {
--- GodotSharp/Generated.old/GodotObjects/LineEdit.cs	2024-03-09 16:46:29.608389400 +0100
+++ GodotSharp/Generated/GodotObjects/LineEdit.cs	2024-03-09 16:48:42.661835600 +0100
@@ -605,7 +605,7 @@
     /// <summary>
     /// <para>Base text writing direction.</para>
     /// </summary>
-    public Control.TextDirection TextDirection
+    public new Control.TextDirection TextDirection
     {
         get
         {
--- GodotSharp/Generated.old/GodotObjects/LinkButton.cs	2024-03-09 16:46:29.609390700 +0100
+++ GodotSharp/Generated/GodotObjects/LinkButton.cs	2024-03-09 16:48:42.663834900 +0100
@@ -82,7 +82,7 @@
     /// <summary>
     /// <para>Base text writing direction.</para>
     /// </summary>
-    public Control.TextDirection TextDirection
+    public new Control.TextDirection TextDirection
     {
         get
         {
--- GodotSharp/Generated.old/GodotObjects/MenuBar.cs	2024-03-09 16:46:29.617415700 +0100
+++ GodotSharp/Generated/GodotObjects/MenuBar.cs		2024-03-09 16:48:42.671836500 +0100
@@ -74,7 +74,7 @@
     /// <summary>
     /// <para>Base text writing direction.</para>
     /// </summary>
-    public Control.TextDirection TextDirection
+    public new Control.TextDirection TextDirection
     {
         get
         {
--- GodotSharp/Generated.old/GodotObjects/RichTextLabel.cs	2024-03-09 16:46:30.229494900 +0100
+++ GodotSharp/Generated/GodotObjects/RichTextLabel.cs	2024-03-09 16:48:43.247380000 +0100
@@ -413,7 +413,7 @@
     /// <summary>
     /// <para>Base text writing direction.</para>
     /// </summary>
-    public Control.TextDirection TextDirection
+    public new Control.TextDirection TextDirection
     {
         get
         {
--- GodotSharp/Generated.old/GodotObjects/TextEdit.cs	2024-03-09 16:46:30.389491200 +0100
+++ GodotSharp/Generated/GodotObjects/TextEdit.cs	2024-03-09 16:48:43.401418000 +0100
@@ -758,7 +758,7 @@
     /// <summary>
     /// <para>Base text writing direction.</para>
     /// </summary>
-    public Control.TextDirection TextDirection
+    public new Control.TextDirection TextDirection
     {
         get
         {

[raulsntos]

Looks good, thanks!

[akien-mga]

Thanks!