Remove unused warnings for bones and skeleton modifications and change some cache reload warning to error in case of failure #89387
Conversation
Ughuuu
force-pushed
the
Skeleton2D-Modifications-Throw-Error-and-Warnings-that-are-not-needed
branch
2 times, most recently
from
e2b179f to
f67dd13
Compare
|
Needs a more descriptive title, it is very vague on what errors and warnings are talked about |
scene/resources/2d/skeleton/skeleton_modification_2d_physicalbones.cpp
Outdated
Show resolved
Hide resolved
Ughuuu
changed the title
Ughuuu
force-pushed
the
Skeleton2D-Modifications-Throw-Error-and-Warnings-that-are-not-needed
branch
from
f67dd13 to
63daffe
Compare
update lint code feedback also don't throw error in case of regular setup when is setup isn't set and we just set a var.
Ughuuu
force-pushed
the
Skeleton2D-Modifications-Throw-Error-and-Warnings-that-are-not-needed
branch
from
98eef42 to
e68634f
Compare
|
Seems to fix all warnings/errors from popping up. And fixes some use cases for cache rebuilding. |
|
It looks like this solves the skeleton errors in a slightly different way than #84474. This PR guards against calling the _cache functions before the skeleton is setup, while the previous PR changed the _cache functions internally to allow them to be called under all conditions without error. I'm uncertain which of these two approaches is better, but only one should probably be merged, as they duplicate fixing the issue in different ways. |
|
Last time someone on that issue said there are still some errors/warnings printed with this PR, so it might miss some cases right now. |
Ughuuu
deleted the
Skeleton2D-Modifications-Throw-Error-and-Warnings-that-are-not-needed
branch
Based on: #73247 (comment)
My findings are on that page, but will put them here also:
The warning doesn't need to be a warning as the bone_cache will be updated anyway during the setup call.
Also some warnings don't need to be warnings at all as they are not actually warnings, but just the value is set initially(eg. bone index) and the cache not computed.