Ensure specialization constants come sorted from reflection #89420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although it's not the end of the world, spec constants can come not sorted by
constant_id. Ensuring they are sorted makes things easier for third-party code (extensions, etc.) that parses them.If at some point
spirv_reflectincludes support for spec constants upstream, we may no longer need this patch, provided their code already sorts them. In the meantime, it's much easier for us to sort in Godot-land, where we havesort()than trying to extend the patch to include a sorting algo in the C code ofspirv_reflect.