Pre-commit: Fix copyright_headers.py to run on all relevant files
#89421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KoBeWi
reviewed
Mar 12, 2024
akien-mga
force-pushed
the
pre-commit-fix-copyright_headers
branch
from
07634f7 to
f833573
Compare
|
Tried locally and it looks good to me |
EIREXE
reviewed
Mar 15, 2024
It was only running on the first file passed by pre-commit, instead of all. Fixes compatibility with Windows paths to get the basename.
akien-mga
force-pushed
the
pre-commit-fix-copyright_headers
branch
from
f833573 to
e520359
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was only running on the first file passed by pre-commit, instead of all. Fixes compatibility with Windows paths to get the basename.
CC @KoBeWi @EIREXE I believe this should fix both issues you raised today.