Reorganized GUIDs in is_xinput_device and added several missing GUIDs, second attempt
#89587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reorganized controller order to match chronological release by hardware. Added missing hardware IDs (two for USB, two that were the result of a firmware update).
|
Never mind, I see the problem wasn't that I didn't link an issue, it's that I was trying to fix a CLOSED issue despite the problem in the issue still manifesting. Will create new, updated issue with new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-submission of #89564 to fix issues present upon submission (still new to this)
Fixes #76724
Fills in some gaps that were left in the issue, especially with the Xbox One S controllers that received new GUIDs after a firmware update. Also reorganizes the GUIDs to reflect chronological release of hardware. Basically just a follow-up on pull #78043