Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AudioStreamInteractiveEditorPlugin GUI bugs #89592

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

caimantilla
Copy link

Adds DPI scaling to the table columns and fixes an error which occurs when clicking the top-right "From / To" cell.

Before:
Screenshot 2024-03-16 at 23 12 40
After:
Screenshot 2024-03-16 at 23 04 15

Comment on lines 151 to 150
if (!p_item->has_meta("to")) {
return;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this line is never supposed to be reached, it might be better to use ERR_FAIL_COND() instead so an error can be printed.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this line is never supposed to be reached, it might be better to use ERR_FAIL_COND() instead so an error can be printed.

It does get reached though, hence why I added it.
It's been a bit since I made this PR, so I'll see if it would instead make sense to always add that metadata.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this line is never supposed to be reached, it might be better to use ERR_FAIL_COND() instead so an error can be printed.

It does get reached though, hence why I added it. It's been a bit since I made this PR, so I'll see if it would instead make sense to always add that metadata.

Now I remember, "to" is an integer referencing a clip. It's not written to the corner cells of the tree (ie. the "From / To" header)
It doesn't make any sense to write it there. Still, checking if "to" exists is a bit specific, so instead I've made it so that each cell has an "is_editable_cell" metadata and check that.

@caimantilla caimantilla force-pushed the interactive-music-editor-fixes branch from 52924fc to eb1cbb1 Compare May 21, 2024 05:41
@KoBeWi KoBeWi modified the milestones: 4.3, 4.4 Jul 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants