Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to import skeleton rest as RESET animation #89629

Merged
1 commit merged into from
Mar 24, 2024

Conversation

lyuma
Copy link
Contributor

@lyuma lyuma commented Mar 18, 2024

Add option "Import Rest as RESET" to generate a RESET animation for a skeleton bone rest pose.

Also creates an AnimationPlayer if one does not exist.
Designed to be used in conjunction with PR #88824, loading rest pose in another importer

When used in conjunction with #88824 , will resolve- #65656 and #89244

Copy link
Member

@TokageItLab TokageItLab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in functionality, but documentation seems to be lacking so needs to add it.

Also creates an AnimationPlayer if one does not exist.
Designed to be used in conjunction with loading rest pose in another importer.
@lyuma lyuma force-pushed the import_rest_as_reset branch from 8871b5f to 34f284b Compare March 19, 2024 09:27
@lyuma lyuma requested a review from a team as a code owner March 19, 2024 09:27
Copy link
Contributor

@Mickeon Mickeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amen

@akien-mga akien-mga closed this pull request by merging all changes into godotengine:master in 06abc86 Mar 24, 2024
akien-mga added a commit that referenced this pull request Mar 24, 2024
Add option to import skeleton rest as RESET animation
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants