-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make "Pick Color"'s result less precise, keep only 3 decimals #89630
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Title of the issue could also be renamed as now it's 3 places.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally (rebased on top of master
2149682), it works as expected.
Rounding to 3 decimals is sufficient to represent any 32-bit color (e.g. in the form of #rrggbbaa
), so it's fine.
Thanks! |
This fixes half of #89354 , the other half I did not observe the problem yet.
The number of decimals is arbitrary, but I suppose 2-3 should be enough.