-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add minimum width/height to dialog buttons #89693
Add minimum width/height to dialog buttons #89693
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #89718. |
This doesn't play well with the |
6d5bd83
to
e8422b8
Compare
I've pushed an update that adjusts padding based on the spacing preset. Spacing with the Default preset was also reduced by a few pixels on both axes. See OP for updated screenshots. |
Way better now! You also need to add docs for the added theme properties. |
e8422b8
to
c14ba32
Compare
This makes buttons with short texts such as "OK" or "Close" easier to click, especially on a touchscreen. This is exposed to projects via `buttons_min_width` and `buttons_min_height` theme items in AcceptDialog (and therefore ConfirmationDialog and FileDialog), with the default values being 0 to preserve compatibility with existing projects.
c14ba32
to
1e85266
Compare
Done. |
Thanks! |
This makes buttons with short texts such as "OK" or "Close" easier to click, especially on a touchscreen.
This is exposed to projects via
buttons_min_width
andbuttons_min_height
theme items in AcceptDialog (and therefore ConfirmationDialog and FileDialog), with the default values being 0 to preserve compatibility with existing projects.Preview
AcceptDialog
ConfirmationDialog