Android: Fix UnsupportedOperationException remove from non-ArrayList #89703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maran23
reviewed
Mar 20, 2024
platform/android/java/lib/src/org/godotengine/godot/utils/PermissionsUtil.java
Outdated
Show resolved
Hide resolved
|
updated in 3262363 to return a mutable list. I don't have access to the test android device any more, so check carefully or test on a pixel tablet running android 14 |
akien-mga
changed the title
m4gr3d
approved these changes
Mar 25, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getManifestPermissionson some versions of android seem to return some other implementation of List<> which does not implementremove()I workaround this crash by converting the generic List<> to an ArrayList<> which is known to support
remove()Tested crash fix on
Pixel TabletAndroid 14:Godot v4.3.dev - Android - Vulkan (Mobile) - integrated Mali-G710 - (8 Threads)
Fixes #89696