Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VisualShader] Remove invalid graph connections when ports are removed #89810

Merged
merged 1 commit into from
Apr 8, 2024
Merged

[VisualShader] Remove invalid graph connections when ports are removed #89810

merged 1 commit into from
Apr 8, 2024

Conversation

Geometror
Copy link
Member

Supercedes #80312. (partial salvage, the undo/redo stuff had to be redone)
Fixes #79417.

invalid-conns-fix

@Geometror Geometror added this to the 4.3 milestone Mar 23, 2024
@Geometror Geometror requested a review from a team as a code owner March 23, 2024 14:41
paddy-exe
paddy-exe approved these changes Apr 1, 2024
View reviewed changes
Copy link
Contributor

@paddy-exe paddy-exe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected. Can't say much about the usage of the unlikely keyword but the explanation makes sense

AThousandShips
AThousandShips approved these changes Apr 1, 2024
View reviewed changes
editor/plugins/visual_shader_editor_plugin.cpp Outdated Show resolved Hide resolved
editor/plugins/visual_shader_editor_plugin.h Outdated Show resolved Hide resolved
@akien-mga akien-mga mentioned this pull request Apr 4, 2024
Closed
@akien-mga
Copy link
Member

@Geometror There are a couple code style/quality comments to address, then it should be good to merge.

@Geometror @EddieBreeg
[VisualShader] Remove invalid graph connections when ports are removed
0b9b479 
Co-authored-by: EddieBreeg <eddiebreeg0@protonmail.com>
@akien-mga akien-mga merged commit 429bf02 into godotengine:master Apr 8, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AThousandShips AThousandShips AThousandShips approved these changes

@paddy-exe paddy-exe paddy-exe approved these changes

Assignees
No one assigned
Labels
bug topic:editor topic:shaders
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

No disconnect when changing node type with less joints in visual shader editor
4 participants
@Geometror @akien-mga @paddy-exe @AThousandShips