Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Buildsystem] Fix encoding when reading files #89858

Merged
1 commit merged into from
Mar 25, 2024

Conversation

AThousandShips
Copy link
Member

I added it to all cases with "r" I could find, didn't add it to "rb" as I assume those are read as binary and won't care about encoding, also there were some cases where there wasn't an explicit mode, left those, but if needed I'll add those too

See:

@akien-mga
Copy link
Member

Would be good to find what caused the regression.

I assume maybe #89361 (cc @Repiteo).

@Repiteo
Copy link
Contributor

Repiteo commented Mar 24, 2024

I'd sooner assume #89333 as a possible culprit, which added explicit utf8 encoding to unspecified writes.

@AThousandShips
Copy link
Member Author

Agreed it seems to be the misalignment between reads and writes, unsure if we should instead remove enforcing it on either, but this solves at least the specific issue in the comment

akien-mga added a commit that referenced this pull request Mar 25, 2024
[Buildsystem] Fix encoding when reading files
@akien-mga akien-mga closed this pull request by merging all changes into godotengine:master in 0acfb38 Mar 25, 2024
@AThousandShips AThousandShips deleted the utf_fix branch March 25, 2024 10:22
@AThousandShips AThousandShips restored the utf_fix branch March 25, 2024 10:22
@AThousandShips AThousandShips deleted the utf_fix branch March 25, 2024 10:22
@akien-mga
Copy link
Member

Thanks!

@AThousandShips
Copy link
Member Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants