-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Work around diff size limit for static checks #89944
Conversation
78659ff
to
59c83cf
Compare
Turns out this doesn't list all the files, but it at least works, as opposed to the other case, unsure how it can be solved better otherwise |
Maybe we should fall back to this solution if the one using If so it'd be a good idea to somehow signal that this fallback has happened. |
I think I have an alternative solution, will push soon |
59c83cf
to
ef68a25
Compare
There, new and better solution works, using the number of commits in the PR from the action, should work well now, will rebase on top of updated PR and check properly Tried to dig into the format and data in the actions but so far I didn't find an explicit list of files, so using a trick with just getting |
ef68a25
to
45db875
Compare
45db875
to
5d4352a
Compare
Can
Done. |
5d4352a
to
446694b
Compare
This comment was marked as outdated.
This comment was marked as outdated.
7d24d02
to
69dc279
Compare
452b4ae
to
62531ea
Compare
Sorry for the false start, reverted to the |
Thanks! |
Thank you! |
Edit 2: Seems it wasn't a false alarm and it just worked partially, new fix up and ready Un-cherry-picked this and the new PR should be cherry-picked instead (manually or otherwise, no need to have a partial fix in there) |
See:
Includes that PR just to verify it will solve the limit issueEdit: Works as expected with the fetch, see here
Affects (as far as I can find):