-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Control z-index warning #89956
Remove Control z-index warning #89956
Conversation
I'm in favor of providing a way to disable this warning. After reading through #69895 it looks like that a dedicated project setting is justified in this case as many users have strong feelings about the presence of that warning :) Well aware that this isn't the best (permanent) solution, but I think it's the best we can currently do without major/breaking changes to the configuration warning system. |
This feels like a band-aid. It would be better to have a way to silence any warning. |
Do you have a specific system in mind for disabling warning though? It was mentioned many times, but no one even opened a proposal so far. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A general control of warning display would be nice, but IMO this is a special case, many other warnings are less relevant to hide (like collision objects without shapes, which isn't really valid, scale warnings, etc.), this one is simply information, rather than something being wrong as such
We might even want to add categories to warnings in the future to distinguish "warnings" from "information", with a white triangle perhaps
This feels pretty hacky to me. And since it needs to be configured in the project settings, users who know and don't care to keep being reminded about this will need to disable it manually in every single project they make that users Z index on Controls. IMO, aside from a more involved system to make configuration warnings more flexible as suggested in godotengine/godot-proposals#9416, this particular one may just need to go. A crystal clear warning in the documentation should be sufficient. We can try, and if we find that too many users are confused, we can add a warning back. But currently we only tried with a warning and thus with users confused by the warning, and not by what it teaches them. |
Where though? In |
Yeah I think so. And maybe a note in the Control description? |
afa1f2a
to
dd0deac
Compare
I removed the warning. Seems like it's sufficiently documented already. |
dd0deac
to
c3d2fab
Compare
Thanks! |
Addresses #69895
The warning message
now mentions that it can be disabled:is completely gone.