C#: Make internal properties and property accessors public (but hidden)

[raulsntos]

Instead of making the accessors internal which can break binary compat, make them public but hide them with EB never so they don't show up in IntelliSense.

Also, do the same for properties with the PROPERTY_USAGE_INTERNAL flag. These properties were not meant to be exposed to scripting, but since they've been public before all we can do now is hide them.

• I think this closes [C# API] Possible type mismatch of property Node.AnchorsPreset #71062 since the property that was confusing should now be hidden.

[AThousandShips]

I like this generally, but one potential compatibility issue:
Does it count as shadowing/blocking internal methods of parent classes in C#?

I.e. if I extend Animation and I decided to add a GetLength method to it, will this break now that Animation.GetLength goes from internal to public? Regardless of that being appropriate or not it's not a method anyone would know existed

Edit: To be clear I don't think it's a major issue, and we often add new methods and that might trigger the same effect, but we're exposing methods en-masse here and it's worth thinking about I think, especially since they're hidden they might cause confusion, depending on how it's handled in C# (I don't know enough of C#, it's been years since I worked with it, so it might just be fine to have shadowing etc.)

[AThousandShips]

We might want to update the comment on this, it speaks of setters and getters but are not internal any longer

[raulsntos]

I think this still applies, it refers to property getters and setters when the method starts with an underscore and are not virtual. For example: AnimationLibrary::_set_data.

[AThousandShips]

This comment as well

[raulsntos]

I.e. if I extend Animation and I decided to add a GetLength method to it, will this break now that Animation.GetLength goes from internal to public?

It doesn't break binary compatibility if that's what you are asking. Your GetLength method shadows the inherited method and that will now give you a warning that you can suppress with the new modifier if shadowing was intended.

[AThousandShips]

That answers my question that the warning isn't an issue as such, as opposed to virtual methods in C++ etc., good!

[akien-mga]

Thanks!