Fix RenderingDevice::get_driver_resource crash or incorrect result with certain resources
#90011
+14
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
changed the title
RenderingDevice::get_driver_resource will crash or give incorrect result with certain resourcesRenderingDevice::get_driver_resource crash or incorrect result with certain resources
DarioSamo
approved these changes
Mar 29, 2024
|
LGTM. That implicit bool casting operator has gotten me too in one other occasion and I think I fixed it in one of my other branches, but it can be on this one, no problem. |
clayjohn
approved these changes
Apr 2, 2024
RandomShaper
reviewed
Apr 3, 2024
…rect result with certain resources
jsjtxietian
force-pushed
the
command-queue
branch
from
ee944d2 to
5a5453b
Compare
RandomShaper
approved these changes
Apr 8, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #89979
cc @DarioSamo Except the changes pointed out by the issue author, I also found a "bug" regarding the implicit operator bool() which could lead to the assignment failed and always be 0 or 1 cause bool() kicks in. (For those interested, here is an example of the behaviour https://godbolt.org/z/q1YfPTMjE)