-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix load subtask not being registered leading to false progress values. #90091
Fix load subtask not being registered leading to false progress values. #90091
Conversation
Hey, I just tested this, and as far as I can tell, it solves all the issues from #90076 while maintaining the improvements from #87711 in elegant fashion. For added context, here are a few outputs from my testing: Case 1:
In the regression, an empty Case 2:
This is the scenario #87711 was meant to fix in the first place. We correctly choose Case 3 would be similar to Case 2, but with Thank you for your contribution and great work!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Asking a few changes. Besides that, the changes make a lot of sense.
18f0d03
to
ca020ad
Compare
Thanks! |
Fixes #90076
I'm clearly not 100% sure about my solution but it works. See #90076 (comment) and the previous comment for a bit more depth on why this is working